[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] Fix a crash when using Open vSwitch virtual ports



On Wed, Aug 29, 2012 at 10:32:38PM -0700, Eric Blake wrote:
> On 08/29/2012 11:44 AM, Kyle Mestery wrote:

> >          /* Trunk port first */
> > -        if (virtVlan->trunk) {
> > -            virBufferAddLit(buf, "trunk=");
> > +        if (virtVlan->trunk == true) {
> 
> 'cond == true' as a condition is a pointless change, 'cond' is sufficient.

  Okay, i pushed a tiny cleanup for this,

   thanks !

Daniel

-- 
Daniel Veillard      | libxml Gnome XML XSLT toolkit  http://xmlsoft.org/
daniel veillard com  | Rpmfind RPM search engine http://rpmfind.net/
http://veillard.com/ | virtualization library  http://libvirt.org/


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]