[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 0/2] Revert to blocking behavior of qemuAgentCommand



On Thu, Aug 30, 2012 at 21:58:12 +0800, Daniel Veillard wrote:
> On Thu, Aug 30, 2012 at 03:12:44PM +0200, Jiri Denemark wrote:
> > Commit 05447e3af44ec153314ff97cd611330d9b4b5730 made changes to
> > qemuAgentCommand so that an arbitrary timeout can be passed to it.
> > However, it did so partially in a very confusing way and partially in a
> > totally wrong way.
> > 
> > Jiri Denemark (2):
> >   qemu: Remove redundant parameter from qemuAgentSend
> >   qemu: Revert to blocking behavior of qemuAgentCommand
> > 
> >  src/qemu/qemu_agent.c | 46 ++++++++++++++++++++++++----------------------
> >  1 file changed, 24 insertions(+), 22 deletions(-)
> 
>   ACK to the set. The core reason is that the new functionality of
> adding arbitrary guest agent command support should not be done at
> the detriment of existing functionality, in that case we get an
> error when using guest agent based shutdown
> 
>    https://bugzilla.redhat.com/show_bug.cgi?id=853002
> 
>   Let's try to get the new API fixed for the next release then

Thanks guys, I pushed this series.

Jirka


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]