[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] qemu: Don't ignore CPU tuning config if required cgroups are missing



On Fri, Aug 31, 2012 at 14:50:32 +0800, Daniel Veillard wrote:
>   A bit of context would be nice
> 
> On Fri, Aug 31, 2012 at 08:23:15AM +0200, Jiri Denemark wrote:
> > ---
> >  src/qemu/qemu_cgroup.c | 29 ++++++++++++++++++++---------
> >  1 file changed, 20 insertions(+), 9 deletions(-)
> > 
>   ACK,

Thanks, I added the following background story to the commit and pushed:

    When domain XML contains any of the elements for setting up CPU
    scheduling parameters (period, quota, emulator_period, or
    emulator_quota) we need cpu cgroup to enforce the configuration.
    However, the existing code would just ignore silently such settings if
    either cgroups were not available at all cpu cgroup was not available.
    Moreover, APIs for manipulating CPU scheduler parameters were already
    failing if cpu cgroup was not available. This patch makes cpu cgroup
    mandatory for all domains that use CPU scheduling elements in their XML.

Jirka


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]