[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] python: don't mask libvirt errors



On 08/31/2012 03:05 PM, Peter Krempa wrote:
> On 08/31/12 19:10, Eric Blake wrote:
>> A user reported this crash when using python bindings:
>>

>>
>> In the python bindings, returning NULL makes python think an
>> exception was thrown, while returning the None object lets the
>> wrappers know that a libvirt error exists.
>>
>> Reported by Nox DaFox, fix suggested by Dan Berrange.
>>
>> * python/libvirt-override.c (libvirt_virDomainBlockPeek)
>> (libvirt_virDomainMemoryPeek): Return python's None object, so
>> wrapper knows to check libvirt error.
>> ---
>>   python/libvirt-override.c | 8 ++++++--
>>   1 file changed, 6 insertions(+), 2 deletions(-)
>>
> 
> ACK.

Thanks; pushed.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]