[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] virsh: don't crash if shutdown --mode not provided



On Fri, Nov 30, 2012 at 02:56:08PM -0700, Eric Blake wrote:
> virStringSplit requires a non-NULL input, but commit cef78ed forgot
> to follow the rule.
> 
> * tools/virsh-domain.c (cmdReboot, cmdShutdown): Avoid NULL deref.
> ---
> 
> Pushing under the build-breaker rule.
> 
>  tools/virsh-domain.c |   12 ++++++------
>  1 files changed, 6 insertions(+), 6 deletions(-)

ACK, thanks for finding this. I guess I forgot to re-run the test
suite after the v2 of my series changing virsh.

Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]