[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] conf: fix virDomainNetGetActualDirect*() and BridgeName()



On 12/03/2012 01:10 PM, Eric Blake wrote:
>> This resolves:
>>
>>    https://bugzilla.redhat.com/show_bug.cgi?id=881480
>>
>> These three functions:
>>
>>   virDomainNetGetActualBridgeName
>>   virDomainNetGetActualDirectDev
>>   virDomainNetGetActualDirectMode
>>
>> return attributes that are in a union whose contents are interpreted
>> differently depending on the actual->type and so they should only
>> return non-0 when actual->type is 'bridge' (in the first case) or
>> 'direct' (in the other two cases, but I had neglected to do that,
>> (The other two functions weren't causing any behavioral problems in
>> virDomainChangeNet(), but their problem and fix was identical, so I
>> included them in this same patch).
>>
>> were supposed to only return non-0 values when
> Spurious line in the commit message.
>

Oops. Forgot to delete that. I removed it before I pushed. Thanks!


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]