[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] RFC: Coding style: require alphabetical header file sorting



On Mon, Dec 03, 2012 at 04:45:26PM +0000, Daniel P. Berrange wrote:
> Thus far we only have one rule about header files, #include <config.h>
> must be first in all .c files.  I'm wondering if it is time to introduce
> some new rules
> 
>  - All system headers must be grouped to preceed all local headers
>  - All system headers must be sorted within their group
>  - All local headers must be sorted within their group
> 
> This will require updating pretty much every single source and header
> file in the tree. Of course it will need a new syntax check rule to
> validate this too.  Since fixing them is a serious amount of work,
> I was wondering about people's opinions on this ?
> 
> The goal is just standardization to make code a little more readable.

FYI, looking at this, I think it is not worth doing until we have
renamed all the files in src/util to have a 'vir' prefix.

We should then probably require that  util headers are included first,
then the driver specific headers, or something like that

Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]