[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] qemu: improve error for failed JSON commands



On 12/04/2012 01:46 PM, Peter Krempa wrote:
> On 12/04/12 21:26, Eric Blake wrote:
>> Only one error in qemu_monitor was already using the relatively
>> new OPERATION_UNSUPPORTED error, even though it is a better fit
>> for all of the messages related to options that are unsupported
>> due to the version of qemu in use rather than due to a user's
>> XML or .conf file choice.  Suggested by Osier Yang.
>>
>> * src/qemu/qemu_monitor.c (qemuMonitorSendFileHandle)
>> (qemuMonitorAddHostNetwork, qemuMonitorRemoveHostNetwork)
>> (qemuMonitorAttachDrive, qemuMonitorDiskSnapshot)
>> (qemuMonitorDriveMirror, qemuMonitorTransaction)
>> (qemuMonitorBlockCommit, qemuMonitorDrivePivot)
>> (qemuMonitorBlockJob, qemuMonitorSystemWakeup)
>> (qemuMonitorGetVersion, qemuMonitorGetMachines)
>> (qemuMonitorGetCPUDefinitions, qemuMonitorGetCommands)
>> (qemuMonitorGetEvents, qemuMonitorGetKVMState)
>> (qemuMonitorGetObjectTypes, qemuMonitorGetObjectProps)
>> (qemuMonitorGetTargetArch): Use better error category.
>> ---
>>   src/qemu/qemu_monitor.c |   40 ++++++++++++++++++++--------------------
>>   1 files changed, 20 insertions(+), 20 deletions(-)
>>
> 
> ACK.

Thanks; pushed.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]