[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] Inhibit daemon shutdown during capabilities probing



On Wed, Dec 05, 2012 at 03:38:04PM -0700, Eric Blake wrote:
> On 12/05/2012 01:17 PM, Guido Günther wrote:
> > As of 1a50ba2cb07d8bb2aa724062889deb9efd7ad9e9 qemu capabilities probing
> > takes longer since we timeout waiting for the monitor socket. When
> > probing qemu for different architectures this can add up so the daemon
> > auto shutdown timeout is reached and the client doesn't have a chance
> > to connect. To avoid that inhibit daemon shutdown during capabilities
> > probing.
> > 
> > This fixes
> > 
> > 	http://honk.sigxcpu.org:8001/job/libvirt-tck-debian-wheezy-qemu-session/227/
> > ---
> >  src/qemu/qemu_driver.c |    7 ++++++-
> >  1 file changed, 6 insertions(+), 1 deletion(-)
> 
> ACK.

Hmm, not sure I agree with this approach. I think that libvirtd code
itself should inhibit shutdown, while 'virStateInitialize' is running.

ie, put the inhibit calls in daemonRunStateInit() in libvirtd.c

Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]