[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] maint: Sort util source file definitions in makefile



On Thu, Dec 06, 2012 at 03:09:20PM +0100, Peter Krempa wrote:
> ---
>  src/Makefile.am | 32 ++++++++++++++++----------------
>  1 file changed, 16 insertions(+), 16 deletions(-)
> 
> diff --git a/src/Makefile.am b/src/Makefile.am
> index 1a2f94f..9aff77a 100644
> --- a/src/Makefile.am
> +++ b/src/Makefile.am
> @@ -54,44 +54,37 @@ augeastest_DATA =
>  UTIL_SOURCES =							\
>  		util/bitmap.c util/bitmap.h			\
>  		util/buf.c util/buf.h				\
> +		util/cgroup.c util/cgroup.h			\
>  		util/command.c util/command.h			\
>  		util/conf.c util/conf.h				\
> -		util/cgroup.c util/cgroup.h			\
> +		util/dnsmasq.c util/dnsmasq.h                   \
> +		util/ebtables.c util/ebtables.h			\
>  		util/event.c util/event.h			\
>  		util/event_poll.c util/event_poll.h		\
>  		util/hooks.c util/hooks.h			\
> +		util/hostusb.c util/hostusb.h			\
>  		util/iptables.c util/iptables.h			\
> -		util/ebtables.c util/ebtables.h			\
> -		util/dnsmasq.c util/dnsmasq.h                   \
>  		util/json.c util/json.h				\
>  		util/logging.c util/logging.h			\
>  		util/memory.c util/memory.h			\
>  		util/pci.c util/pci.h				\
>  		util/processinfo.c util/processinfo.h		\
> -		util/hostusb.c util/hostusb.h			\
>  		util/sexpr.c util/sexpr.h			\
>  		util/stats_linux.c util/stats_linux.h		\
>  		util/storage_file.c util/storage_file.h		\
>  		util/sysinfo.c util/sysinfo.h			\
> -		util/threads.c util/threads.h			\
> +		util/threadpool.c util/threadpool.h		\
>  		util/threads-pthread.h				\
>  		util/threads-win32.h				\
> -		util/threadpool.c util/threadpool.h		\
> -		util/uuid.c util/uuid.h				\
> +		util/threads.c util/threads.h			\
>  		util/util.c util/util.h				\
> +		util/uuid.c util/uuid.h				\
>  		util/viratomic.h util/viratomic.c		\
>  		util/viraudit.c util/viraudit.h			\
>  		util/virauth.c util/virauth.h			\
>  		util/virauthconfig.c util/virauthconfig.h	\
> -		util/virfile.c util/virfile.h			\
> -		util/virnodesuspend.c util/virnodesuspend.h	\
> -		util/virobject.c util/virobject.h		\
> -		util/virpidfile.c util/virpidfile.h		\
> -		util/virprocess.c util/virprocess.h		\
> -		util/virtypedparam.c util/virtypedparam.h	\
> -		util/xml.c util/xml.h				\
> -		util/virterror.c util/virterror_internal.h	\
>  		util/virdbus.c util/virdbus.h			\
> +		util/virfile.c util/virfile.h			\
>  		util/virhash.c util/virhash.h			\
>  		util/virhashcode.c util/virhashcode.h           \
>  		util/virinitctl.c util/virinitctl.h		\
> @@ -110,11 +103,18 @@ UTIL_SOURCES =							\
>  		util/virnetdevvlan.h util/virnetdevvlan.c \
>  		util/virnetdevvportprofile.h util/virnetdevvportprofile.c \
>  		util/virnetlink.c util/virnetlink.h		\
> +		util/virnodesuspend.c util/virnodesuspend.h	\
> +		util/virobject.c util/virobject.h		\
> +		util/virpidfile.c util/virpidfile.h		\
> +		util/virprocess.c util/virprocess.h		\
>  		util/virrandom.h util/virrandom.c		\
>  		util/virsocketaddr.h util/virsocketaddr.c \
>  		util/virstring.h util/virstring.c \
> +		util/virterror.c util/virterror_internal.h	\
>  		util/virtime.h util/virtime.c \
> -		util/viruri.h util/viruri.c
> +		util/virtypedparam.c util/virtypedparam.h	\
> +		util/viruri.h util/viruri.c	\
> +		util/xml.c util/xml.h

This is a worthy change, but I should point out that I'm actually
trying to rename the files in src/util/ that don't have a 'vir'
prefix, which will require re-sorting this list again. So perhaps
best to leave this patch & let me incorporate it when I rename
the source files

Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]