[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] Convert libxl driver to Xen 4.2



Eric Blake wrote:
> On 11/30/2012 03:13 PM, Jim Fehlig wrote:
>   
>> Based on a patch originally authored by Daniel De Graaf
>>
>>   http://lists.xen.org/archives/html/xen-devel/2012-05/msg00565.html
>>
>> This patch converts the Xen libxl driver to support only Xen >= 4.2.
>> Support for Xen 4.1 libxl is dropped since that version of libxl is
>> designated 'technology preview' only and is incompatible with Xen 4.2
>> libxl.  Additionally, the default toolstack in Xen 4.1 is still xend,
>> for which libvirt has a stable, functional driver.
>> ---
>> V2:
>>   Remove 128 vcpu limit.
>>   Remove split_string_into_string_list() function copied from xen
>>   sources since libvirt now has virStringSplit().
>>     
>
> Tested on Fedora 18, with its use of xen 4.2.  ACK; let's get this pushed.
>   

Thanks, pushed.

>   
>> @@ -62,7 +64,6 @@ struct guest_arch {
>>  static const char *xen_cap_re = "(xen|hvm)-[[:digit:]]+\\.[[:digit:]]+-(x86_32|x86_64|ia64|powerpc64)(p|be)?";
>>  static regex_t xen_cap_rec;
>>  
>> -
>>  static int
>>  libxlNextFreeVncPort(libxlDriverPrivatePtr driver, int startPort)
>>  {
>>     
>
> This looks like a spurious whitespace change in isolation, but as long
> as the overall file is consistent on one vs. two blank lines before
> functions, I don't care if you keep or drop this hunk.
>   

That was spurious, and removed before pushing.

Regards,
Jim


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]