[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 00/15 v5] Unprivileged SG_IO support



On 12/05/2012 02:25 AM, Osier Yang wrote:
> Hi,
> 
> As a result of RFC [1], this implements the unprivleged SG_IO
> support. Testing is not that enough, but I'd like see the
> reviewing earlier, and meanwhile I'm not going to give up
> the further testing.

I didn't see where [1] links to.

> 
> Patches 1/10 ~ 4/10 are to introduce the internal list for shared
> disks.
> 
> Osier Yang (15):
>   qemu: Introduce a list to maintain the shared disks between domains
>   qemu: Init/Free the list with the driver's lifecyle
>   qemu: Add/remove the shared disk entry during domain's lifecyle
>   qemu: Add/Remove the entry of sharedDisks when live
>     attaching/detaching

Are you properly handling backing files as potential shared disks?  I
think we really need to reach the point where we can specify the entire
backing chain as part of domain XML, and where we fill in the backing
chain if the user didn't provide it up front.  After all, it is entirely
reasonable to allow for:

base <- A.img
     <- B.img

where A.img is used by domain A, B.img is used by domain B, but where
we'd like to have SG_IO support for both domain's read-only use of base.
 I don't know if this will impact what needs to happen in your series.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]