[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 5/5] [OPTIONAL] qemu: allow save and managedsave on guests marked as autodestroyable

2012/12/7 Peter Krempa <pkrempa redhat com>
I don't see any reason to forbid saving machines that should be
autodestroyed. I will squash this to the previous one if this is okay.
 src/qemu/qemu_driver.c | 6 ------
 1 file changed, 6 deletions(-)

diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c
index 7e19cdc..e5b6295 100644
--- a/src/qemu/qemu_driver.c
+++ b/src/qemu/qemu_driver.c
@@ -3005,12 +3005,6 @@ qemuDomainSaveInternal(virQEMUDriverPtr driver, virDomainPtr dom,
     virDomainEventPtr event = NULL;
     qemuDomainObjPrivatePtr priv = vm->privateData;

-    if (qemuProcessAutoDestroyActive(driver, vm)) {
-        virReportError(VIR_ERR_OPERATION_INVALID,
-                       "%s", _("domain is marked for auto destroy"));
-        goto cleanup;
-    }
     if (!qemuMigrationIsAllowed(driver, vm, vm->def, false))
         goto cleanup;

I think, if a vm is marked has autodestroyed,then this means that we do not need this vm again on next reboot.? if so,what's the reason for us to save this vm?
if we want to save it,why we marked it has autodestroyed? ^ ^

[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]