[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH v16] support offline migration

On 12/07/2012 08:08 AM, Jiri Denemark wrote:
> From: liguang <lig fnst cn fujitsu com>
> original migration did not aware of offline case,
> so, try to support offline migration quietly
> (did not disturb original migration) by pass
> VIR_MIGRATE_OFFLINE flag to migration APIs if only
> the domain is really inactive, and
> migration process will not puzzled by domain
> offline and exit unexpectedly.
> these changes did not take care of disk images the
> domain required, for them could be transferred by
> other APIs as suggested, then VIR_MIGRATE_OFFLINE
> must not combined with VIR_MIGRATE_NON_SHARED_*.
> and you must do a persistent migration at same time,
> do "virsh migrate --offline --persistent ...".
> Signed-off-by: liguang <lig fnst cn fujitsu com>
> ---
> This patch is a combination of v15 from liguang and my changes I sent as
> review comments to that v15. Since I had to do quite a few changes, I
> didn't push the result right away even though this has my ACK now. I'll
> wait until next week and if no comments appear, I'll push this patch at
> the beginning of next week.

You also have my ACK.  However, I think we need a followup patch to
docs/migration.html.in to mention details about offline migration.

Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature

[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]