[libvirt] [PATCH 02/23] Refactor virDomainHostdevFind method
Eric Blake
eblake at redhat.com
Tue Dec 11 00:22:29 UTC 2012
On 11/30/2012 01:26 PM, Daniel P. Berrange wrote:
> From: "Daniel P. Berrange" <berrange at redhat.com>
>
> Move the code for matching hostdev instances out of virDomainHostdevFind
> and into virDomainHostdevMatch method, which in turn calls out to other
> helper methods depending on the type of hostdev.
>
> Signed-off-by: Daniel P. Berrange <berrange at redhat.com>
> ---
> src/conf/domain_conf.c | 108 +++++++++++++++++++++++++++++--------------------
> 1 file changed, 65 insertions(+), 43 deletions(-)
Looks like a reasonable refactor. It adds lines, but will make future
tweaks to a single hostdev type easier and less nested.
ACK.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 619 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20121210/a62ce5f0/attachment-0001.sig>
More information about the libvir-list
mailing list