[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 02/23] Refactor virDomainHostdevFind method



On 11/30/2012 01:26 PM, Daniel P. Berrange wrote:
> From: "Daniel P. Berrange" <berrange redhat com>
> 
> Move the code for matching hostdev instances out of virDomainHostdevFind
> and into virDomainHostdevMatch method, which in turn calls out to other
> helper methods depending on the type of hostdev.
> 
> Signed-off-by: Daniel P. Berrange <berrange redhat com>
> ---
>  src/conf/domain_conf.c | 108 +++++++++++++++++++++++++++++--------------------
>  1 file changed, 65 insertions(+), 43 deletions(-)

Looks like a reasonable refactor.  It adds lines, but will make future
tweaks to a single hostdev type easier and less nested.

ACK.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]