[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCHv2 6/7] conf: put data for network <forward> element into its own struct



On 12/10/2012 02:23 PM, Laine Stump wrote:
> The attributes of a <network> element's <forward> element were
> previously stored directly in the virNetworkDef object, but
> virNetworkUpdateForward() needs to operate on a <forward> in
> isolation, so this patchs pulls out all those attributes into a

s/patchs/patch/

> separate virNetworkForwardDef struct (and shortens their names
> appropriately). This new object is contained in the virNetworkDef, not
> pointed to by it, so there is no extra memory management.
> 
> This patch makes no functional changes, it only changes, e.g.,
> "nForwardIfs" to "forward.nifs".
> ---
>  src/conf/network_conf.c      | 148 ++++++++++++++++-----------------
>  src/conf/network_conf.h      |  34 ++++----
>  src/esx/esx_network_driver.c |  30 +++----
>  src/network/bridge_driver.c  | 192 +++++++++++++++++++++----------------------
>  src/vbox/vbox_tmpl.c         |   4 +-
>  5 files changed, 207 insertions(+), 201 deletions(-)

Again, mostly mechanical.  ACK.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]