[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 1/5] qemu: Restart CPUs with valid async job type when doing external snapshots



On 12/07/2012 12:29 PM, Peter Krempa wrote:
> When restarting CPUs after an external snapshot, the restarting function
> was called without the appropriate async job type. This caused that a
> new sync job wasn't created and allowed races in the monitor.
> ---
>  src/qemu/qemu_driver.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c
> index e099c5c..6f8f840 100644
> --- a/src/qemu/qemu_driver.c
> +++ b/src/qemu/qemu_driver.c
> @@ -11481,7 +11481,7 @@ endjob:
>      if (resume && vm && virDomainObjIsActive(vm) &&
>          qemuProcessStartCPUs(driver, vm, conn,
>                               VIR_DOMAIN_RUNNING_UNPAUSED,
> -                             QEMU_ASYNC_JOB_NONE) < 0) {
> +                             QEMU_ASYNC_JOB_SNAPSHOT) < 0) {
>          virDomainEventPtr event = NULL;
>          event = virDomainEventNewFromObj(vm,
>                                           VIR_DOMAIN_EVENT_SUSPENDED,
> 

Makes sense, ACK.

Martin


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]