[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 3/5] qemu: snapshot: Report better error message if migration isn't allowed



On 12/07/2012 04:30 AM, Peter Krempa wrote:
> Qemu doesn't support migration on guests with host devices. This patch
> adds a check to ensure migration is safe before actualy doing so.

s/actualy/actually/

> ---
>  src/qemu/qemu_driver.c | 4 ++++
>  1 file changed, 4 insertions(+)

ACK.

> 
> diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c
> index 6f8f840..4423e69 100644
> --- a/src/qemu/qemu_driver.c
> +++ b/src/qemu/qemu_driver.c
> @@ -11428,6 +11428,10 @@ qemuDomainSnapshotCreateActiveExternal(virConnectPtr conn,
> 
>      /* do the memory snapshot if necessary */
>      if (memory) {
> +        /* check if migration is possible */
> +        if (!qemuMigrationIsAllowed(driver, vm, vm->def, false))
> +            goto endjob;
> +
>          /* allow the migration job to be cancelled or the domain to be paused */
>          qemuDomainObjSetAsyncJobMask(vm, DEFAULT_JOB_MASK |
>                                       JOB_MASK(QEMU_JOB_SUSPEND) |
> 

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]