[libvirt] [PATCH v3 1/8] bandwidth: Attach sfq to leaf node

[Laine Stump]

On 12/11/2012 11:09 AM, Michal Privoznik wrote:
> SFQ is qdisc which doesn't really shape any traffic but
> 'just' re-arrange packets in sending buffer so no stream
> starve.  The goal is to ensure fairness. There is basically
> only one configuration parameter (perturb) which is set to
> advised value of 10.
> ---

ACK, but please include the meaning of "SFQ and "qdisc" in the commit
message (just what the letters stand for / full word is enough).

>  src/util/virnetdevbandwidth.c |    9 +++++++++
>  1 files changed, 9 insertions(+), 0 deletions(-)
>
> diff --git a/src/util/virnetdevbandwidth.c b/src/util/virnetdevbandwidth.c
> index bddb788..49fc425 100644
> --- a/src/util/virnetdevbandwidth.c
> +++ b/src/util/virnetdevbandwidth.c
> @@ -103,6 +103,15 @@ virNetDevBandwidthSet(const char *ifname,
>  
>          virCommandFree(cmd);
>          cmd = virCommandNew(TC);
> +        virCommandAddArgList(cmd, "qdisc", "add", "dev", ifname, "parent",
> +                             "1:1", "handle", "2:", "sfq", "perturb",
> +                             "10", NULL);
> +
> +        if (virCommandRun(cmd, NULL) < 0)
> +            goto cleanup;
> +
> +        virCommandFree(cmd);
> +        cmd = virCommandNew(TC);
>          virCommandAddArgList(cmd,"filter", "add", "dev", ifname, "parent",
>                               "1:0", "protocol", "ip", "handle", "1", "fw",
>                               "flowid", "1", NULL);