[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH v2 1/4] qemu: add qemu various VGA devices Caps flag



On 12/11/2012 07:14 AM, Guannan Ren wrote:
> QEMU_CAPS_DEVICE_QXL          -device qxl
> QEMU_CAPS_DEVICE_VGA          -device VGA
> QEMU_CAPS_DEVICE_CIRRUS_VGA   -device cirrus-vga
> QEMU_CAPS_DEVICE_VMWARE_SVGA  -device vmware-svga
> 
> Fix a typo in qemuCapsObjectTypes, the string 'qxl' here
> should be -device qxl rather than -vga [...|qxl|..]
> ---
>  src/qemu/qemu_capabilities.c | 10 ++++++++-
>  src/qemu/qemu_capabilities.h |  4 ++++
>  tests/qemuhelptest.c         | 48 +++++++++++++++++++++++++++++++++++---------
>  3 files changed, 52 insertions(+), 10 deletions(-)
> 

> @@ -477,7 +481,6 @@ mymain(void)
>              QEMU_CAPS_NESTING,
>              QEMU_CAPS_NAME_PROCESS,
>              QEMU_CAPS_SMBIOS_TYPE,
> -            QEMU_CAPS_VGA_QXL,
>              QEMU_CAPS_SPICE,
>              QEMU_CAPS_VGA_NONE,
>              QEMU_CAPS_MIGRATE_QEMU_FD,

I'm slightly worried about this one - if someone is running this version
of qemu, and then upgrades and restarts libvirtd, the fact that the
capability disappears may make the running guest disappear from the new
libvirtd.  But I don't have any suggestions on how to make it better; I
guess we'll just have to wait and see if we have any bug reports.

ACK.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]