[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 1/N] qemu driver FreeBSD support: fix compilation



On Tue, Dec 11, 2012 at 23:08:07 +0400, Roman Bogorodskiy wrote:
> Another round of the FreeBSD patches. Here's the first chunk to fix
> compilation.
> 
> Roman Bogorodskiy
...
> diff --git a/src/qemu/qemu_process.c b/src/qemu/qemu_process.c
> index ab04599..5d355eb 100644
> --- a/src/qemu/qemu_process.c
> +++ b/src/qemu/qemu_process.c
> @@ -27,7 +27,12 @@
>  #include <sys/stat.h>
>  #include <sys/time.h>
>  #include <sys/resource.h>
> +#if defined(__linux__)
>  #include <linux/capability.h>
> +#elif defined(__FreeBSD__)
> +#include <sys/param.h>
> +#include <sys/cpuset.h>
> +#endif

In libvirt, we indent nested preprocesor directives, thus the above should
look as follows:

#if defined(__linux__)
# include <linux/capability.h>
#elif defined(__FreeBSD__)
# include <sys/param.h>
# include <sys/cpuset.h>
#endif

make syntax-check is able to detect this kind of issues if you have cppi
installed. And it seems devel/cppi is available in FreeBSD ports so it should
be easy enough to get :-)

Jirka


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]