[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 2/2] add vnc unix sockets to apparmor policy (v2)



Quoting Eric Blake (eblake redhat com):
> On 12/11/2012 01:25 PM, Daniel P. Berrange wrote:
> > On Tue, Dec 11, 2012 at 08:20:30PM +0000, serge hallyn com wrote:
> 
> Instead of putting '(v2)' as a suffix (which I then have to manually
> strip via 'git commit --amend'), it is nicer to put it in the prefix
> [PATCHv2 2/2] (doable with 'git send-email --subject-prefix=PATCHv2',
> and which gets auto-stripped by 'git am').

...

> Likewise, patch changelogs belong best after a --- separator; it's
> useful for the review, but doesn't need to live in git history.

...

Sorry (I actually thought that info was wanted in git history).  Have
noted to make those changes in the future.

> I fixed the commit messages and this alignment,
> 
> > 
> > ACK
> 
> then pushed the series.

Thanks.

-serge


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]