[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH v2 3/4] qemu: use newer -device video device in qemu commandline



On 12/11/12 19:25, Eric Blake wrote:
>> > +    bool qemu1dot2plus = qemuCapsGetVersion(caps) >= 1002000;
> Eww.  Version string comparison is wrong, as it is feasible that someone
> could backport the improved command line to older qemu.  We should
> instead be going off of whether specific '-device XXX' is supported;
> probably by checking for QEMU_CAPS_DEVICE_QXL.

Isn't going to fly.  -device VGA is present for a loooooooong time
already, but only very recently it started to actually work.  So
checking for the devices being present isn't an option.

The change which made it work is avi's memory api, which fixed a nasty
initialization order issue.  That change is invasive enougth that you
don't have to worry about backports at all.

cheers,
  Gerd


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]