[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] Support network boot for HVM guests in libxl



On 12/12/2012 02:42 PM, Jim Fehlig wrote:
> The libxl driver ignored boot devices in the domain config,
> preventing PXE booting HVM domains.  This patch accounts for
> user-specified boot devices when building the libxl domain
> configuration.
> ---
> 
> I'm inclined to call this a bug fix since it is not possible
> to network boot HVM guests without this patch.  Would it be
> ok to push this for 1.0.1?

Agreed; I'm fine with pushing now.

ACK.

> 
>  src/libxl/libxl_conf.c | 30 ++++++++++++++++++++++++++++++
>  1 file changed, 30 insertions(+)
> 
> diff --git a/src/libxl/libxl_conf.c b/src/libxl/libxl_conf.c
> index 5b6d6fb..4c0e961 100644
> --- a/src/libxl/libxl_conf.c
> +++ b/src/libxl/libxl_conf.c
> @@ -438,6 +438,8 @@ libxlMakeDomBuildInfo(virDomainDefPtr def, libxl_domain_config *d_config)
>      b_info->max_memkb = def->mem.max_balloon;
>      b_info->target_memkb = def->mem.cur_balloon;
>      if (hvm) {
> +        char bootorder[VIR_DOMAIN_BOOT_LAST+1];

Style nit: spaces around '+'.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]