[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] selinux: fix NULL dereference in GetSecurityMountOptions



On Thu, Dec 13, 2012 at 11:44:37AM +0100, Ján Tomko wrote:
> In the case of an OOM error in virDomainDefGetSecurityLabelDef, secdef
> is set to NULL, then dereferenced while printing the debug message.
> ---
>  src/security/security_selinux.c |    3 ++-
>  1 files changed, 2 insertions(+), 1 deletions(-)
> 
> diff --git a/src/security/security_selinux.c b/src/security/security_selinux.c
> index 5409e32..9134bc8 100644
> --- a/src/security/security_selinux.c
> +++ b/src/security/security_selinux.c
> @@ -1993,7 +1993,8 @@ virSecuritySELinuxGetSecurityMountOptions(virSecurityManagerPtr mgr,
>          return NULL;
>      }
>  
> -    VIR_DEBUG("imageLabel=%s opts=%s", secdef->imagelabel, opts);
> +    VIR_DEBUG("imageLabel=%s opts=%s",
> +              secdef ? secdef->imagelabel : "(null)", opts);
>      return opts;
>  }
>  

ACK


Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]