[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 2/3] Add lots of debugging to storage file probing code



On 12/13/12 15:26, Daniel P. Berrange wrote:
From: "Daniel P. Berrange" <berrange redhat com>

Signed-off-by: Daniel P. Berrange <berrange redhat com>
---
  src/util/storage_file.c | 12 ++++++++++++
  1 file changed, 12 insertions(+)

diff --git a/src/util/storage_file.c b/src/util/storage_file.c
index 4281d90..69a66ff 100644
--- a/src/util/storage_file.c
+++ b/src/util/storage_file.c
@@ -628,6 +628,9 @@ virStorageFileMatchesVersion(int format,
              (buf[fileTypeInfo[format].versionOffset+2] << 8) |
              (buf[fileTypeInfo[format].versionOffset+3]);
      }
+
+    VIR_DEBUG("Compare version %d vs %d",

I'd write this as "Detected version %d, expected version %d" or something to clarify which was detected without looking into the code.

+              version, fileTypeInfo[format].versionNumber);
      if (version != fileTypeInfo[format].versionNumber)
          return false;


ACK with the message tweaked.

Peter


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]