[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] install: fix virtlockd installation



On Fri, Dec 14, 2012 at 16:50:17 +0800, Osier Yang wrote:
> On 2012年12月14日 07:49, Eric Blake wrote:
> > The virtlockd daemon scripts were lousy, when compared to their
> > counterparts in daemon/Makefile.am.  In particular, when init
> > scripts were selected, this resulted in 'make distcheck' failing
> > due to failure to clean up src/virtlockd.init.
> >
> > * src/Makefile.am (install-systemd): Fix dependencies.  Use MKDIR_P.
> > (uninstall-systemd): Remove empty directory.  Use fewer processes.
> > (install-init, install-sysconfig): Use MKDIR_P.
> > (uninstall-init): Remove correct file, and also empty directory.
> > (uninstall-sysconfig): Remove empty directory.
> > (CLEANFILES): Clean up built sources.
> > ---
> >   src/Makefile.am | 18 +++++++++++-------
> >   1 file changed, 11 insertions(+), 7 deletions(-)
> >
> > diff --git a/src/Makefile.am b/src/Makefile.am
> > index 25b6e3f..dd7e219 100644
> > --- a/src/Makefile.am
> > +++ b/src/Makefile.am
...
> > @@ -2050,5 +2053,6 @@ endif
> >   	rmdir "$(DESTDIR)$(localstatedir)/lib/libvirt" ||:
> >
> >   CLEANFILES += *.gcov .libs/*.gcda .libs/*.gcno *.gcno *.gcda *.i *.s
> > +CLEANFILES += $(BUILT_SOURCES)

I think this is dangerous. IIRC, BUILT_SOURCES includes files we
distribute in the tarball, such as those generated from *.x

Jirka


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]