[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH v4 1/4] qemu: add qemu vga devices caps and one cap to mark them usable



On 12/14/2012 12:06 AM, Guannan Ren wrote:
> QEMU_CAPS_DEVICE_QXL          -device qxl
> QEMU_CAPS_DEVICE_VGA          -device VGA
> QEMU_CAPS_DEVICE_CIRRUS_VGA   -device cirrus-vga
> QEMU_CAPS_DEVICE_VMWARE_SVGA  -device vmware-svga
> 
> QEMU_CAPS_DEVICE_VIDEO_PRIMARY  /* safe to use -device XXX
>                                  for primary video device */
> 
> Fix a typo in qemuCapsObjectTypes, the string 'qxl' here
> should be -device qxl rather than -vga [...|qxl|..]
> ---
>  src/qemu/qemu_capabilities.c | 14 ++++++++++++-
>  src/qemu/qemu_capabilities.h |  5 +++++
>  tests/qemuhelptest.c         | 50 ++++++++++++++++++++++++++++++++++++--------
>  3 files changed, 59 insertions(+), 10 deletions(-)

Much better.  ACK; but I'd like a second opinion on whether this is a
candidate on 1.0.1 or whether we should wait until post-release, since
it missed rc2.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]