[libvirt] [PATCH] build: Fix AUTHORS generation
Eric Blake
eblake at redhat.com
Fri Dec 14 16:41:44 UTC 2012
On 12/14/2012 08:19 AM, Jiri Denemark wrote:
> Using s/#authorslist#/$$out/ makes perl eat @domain part of all email
> addresses from $out since it tries to interpret them as array variables.
> I'm not sure if we can escape those in s/// but I know we can use print:
>
> s/#authorslist#// and print '$$out'
>
> to tell perl not to even inside $out.
>
> This patch also fixes gen-AUTHORS so that it works in VPATH.
> ---
> Makefile.am | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
> gen-AUTHORS:
> - $(AM_V_GEN)if test -d .git; then \
> - out="`git log --pretty=format:'%aN <%aE>' | sort -u`" && \
> - cat $(srcdir)/AUTHORS.in | perl -p -e "s/#authorslist#/$$out/" > \
> + $(AM_V_GEN)if test -d $(srcdir)/.git; then \
> + out="`cd $(srcdir) && git log --pretty=format:'%aN <%aE>' | sort -u`" && \
> + cat $(srcdir)/AUTHORS.in | perl -p -e "s/#authorslist#// and print '$$out'" > \
ACK, although this would be a nice time to fix the useless use of cat:
perl -p -e "s/#authorslist#// and print '$$out'" \
< $(srcdir)/AUTHORS.in > $(distdir)/AUTHORS-tmp && \
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 619 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20121214/45220cc3/attachment-0001.sig>
More information about the libvir-list
mailing list