[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] network: fix (non)update of dnsmasq config during virDomainUpdateDeviceFlags



On 12/14/2012 01:01 PM, Eric Blake wrote:
> On 12/14/2012 10:50 AM, Laine Stump wrote:
>> A forgotten "!" in recently-modified code at the top of
>> networkRefreshDaemon() meant an improper early return, which led to 1)
>> dnsmasq config files not being updated from the newly modified config,
>> and 2) dnsmasq not being sent a SIGHUP so that it could learn about
>> the changes to the config.
>>
>> virNetworkDefGetIpByIndex() returns NULL if there are no ip objects of
>> the requested type, and if there are no IP elements, then dnsmasq
>> shouldn't be running, so we can return early. Otherwise we should
>> rewrite the config files and send a SIGHUP.
>> ---
>>  src/network/bridge_driver.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
> ACK.  You probably spent more time chasing the cause than actually
> fixing the one line :)

Nah. gdb is your friend. :-) (the most time was spent testing to make
sure things once again worked)


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]