[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 4/8] conf: Parse and format the new XML tag cdbfilter



On 12/13/2012 12:05 PM, Osier Yang wrote:
> Setting "cdbfilter" to "no" to enable the unprivleged SG_IO, I.e.
> Disable the kernel CDB filtering.  And "yes" to enable it. "yes"
> is the kernel default behaviour. Later patch will do the actual
> setting.

See my comments on 3/8; I'd much rather see us turn the existing rawio
attribute into a tri-value, than to introduce a competing attribute that
is mutually exclusive with rawio but has the same end goal of allowing
SG_IO.  This patch gets much smaller if you merely add a new value to
the existing rawio enum instead of a new attribute.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]