[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 3/4] conf: cpu: Refactor parsing of vendor_id and fallback attributes



On 12/17/2012 12:22 PM, Peter Krempa wrote:
> This patch simplifies the code that parses the fallback and vendor_id
> attributes from the domain xml cpu definition.
> 
> Changes done:
> - free temp variables in the cleanup section instead of local use
> - remove checking for presence of the attribute to directly getting the
> value (saving call to virXPathBoolean)
> - remove loop used to check for ',' in the vendor_id string with strchr

s/remove/replace/

ACK,

Martin


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]