[libvirt] [PATCH] build: libvirt-guests files misplaced in specfile

Viktor Mihajlovski mihajlov at linux.vnet.ibm.com
Mon Dec 17 15:31:42 UTC 2012


In a non-systemd environment the post and preun scripts of libvirt-client
fail, since the required files are in libvirt-daemon. Moved them to client.
One curious thing: %{_unitdir}/libvirt-guests.service was contained in
both libvirt-client and libvirt-daemon. I removed the extra copy from
daemon.
Note: this should be checked by someone building RPMs for a systemd
machine. I don't have one at the moment.

Signed-off-by: Viktor Mihajlovski <mihajlov at linux.vnet.ibm.com>
---
 libvirt.spec.in |    6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/libvirt.spec.in b/libvirt.spec.in
index 7457a48..b826a8f 100644
--- a/libvirt.spec.in
+++ b/libvirt.spec.in
@@ -1662,15 +1662,12 @@ fi
 
 %dir %attr(0700, root, root) %{_sysconfdir}/libvirt/nwfilter/
 
-%attr(0755, root, root) %{_libexecdir}/libvirt-guests.sh
 %if %{with_systemd}
 %{_unitdir}/libvirtd.service
-%{_unitdir}/libvirt-guests.service
 %{_unitdir}/virtlockd.service
 %{_unitdir}/virtlockd.socket
 %else
 %{_sysconfdir}/rc.d/init.d/libvirtd
-%{_sysconfdir}/rc.d/init.d/libvirt-guests
 %{_sysconfdir}/rc.d/init.d/virtlockd
 %endif
 %doc daemon/libvirtd.upstart
@@ -1948,8 +1945,11 @@ rm -f $RPM_BUILD_ROOT%{_sysconfdir}/sysctl.d/libvirtd
 
 %if %{with_systemd}
 %{_unitdir}/libvirt-guests.service
+%else
+%{_sysconfdir}/rc.d/init.d/libvirt-guests
 %endif
 %config(noreplace) %{_sysconfdir}/sysconfig/libvirt-guests
+%attr(0755, root, root) %{_libexecdir}/libvirt-guests.sh
 %dir %attr(0755, root, root) %{_localstatedir}/lib/libvirt/
 
 %if %{with_sasl}
-- 
1.7.9.5




More information about the libvir-list mailing list