[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 0/6] Use enum for tracking valid architectures



On Tue, Dec 11, 2012 at 11:36:35PM +0800, Daniel Veillard wrote:
> On Tue, Dec 11, 2012 at 02:53:35PM +0000, Daniel P. Berrange wrote:
> > Different operating systems have different names for architectures.
> > eg x86_64 x64, amd64. This can cause inconsistency in libvirt code
> > dealing with architectures. To deal with this define an enum for
> > valid architectures and a canonical string mapping. Update all
> > code internally to use the enum instead of 'char *' for arch
> > data.
> 
>   Sounds a good idea but a bit late for 1.0.1

Be nice to have this reviewed now that 1.0.1 is out

Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]