[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCHv3 3/3] tests: Add tests for sysinfo



On Fri, Dec 14, 2012 at 04:08:25PM +0100, Viktor Mihajlovski wrote:
> Test cases for virSysinfoRead. Initially, there are tests for
> x86 (DMI based) and s390 (/proc/... based).
> In lack of PPC data, I have stubbed out the test for it, but it
> can be added with a minimal effort.

Cool, top marks for doing the x86 impl while you were looking
at s390.

> Signed-off-by: Viktor Mihajlovski <mihajlov linux vnet ibm com>
> ---
>  cfg.mk                               |    2 +-
>  tests/Makefile.am                    |    6 +
>  tests/sysinfodata/dmidecode.sh       |    3 +
>  tests/sysinfodata/s390cpuinfo.data   |   12 ++
>  tests/sysinfodata/s390sysinfo.data   |  114 +++++++++++++++++++
>  tests/sysinfodata/s390sysinfo.expect |   25 +++++
>  tests/sysinfodata/x86sysinfo.data    |   83 ++++++++++++++
>  tests/sysinfodata/x86sysinfo.expect  |   53 +++++++++
>  tests/sysinfotest.c                  |  200 ++++++++++++++++++++++++++++++++++
>  9 files changed, 497 insertions(+), 1 deletion(-)
>  create mode 100755 tests/sysinfodata/dmidecode.sh
>  create mode 100644 tests/sysinfodata/s390cpuinfo.data
>  create mode 100644 tests/sysinfodata/s390sysinfo.data
>  create mode 100644 tests/sysinfodata/s390sysinfo.expect
>  create mode 100644 tests/sysinfodata/x86sysinfo.data
>  create mode 100644 tests/sysinfodata/x86sysinfo.expect
>  create mode 100644 tests/sysinfotest.c

ACK


Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]