[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] build: Fix AUTHORS generation



On Fri, Dec 14, 2012 at 09:41:44 -0700, Eric Blake wrote:
> On 12/14/2012 08:19 AM, Jiri Denemark wrote:
> > Using s/#authorslist#/$$out/ makes perl eat @domain part of all email
> > addresses from $out since it tries to interpret them as array variables.
> > I'm not sure if we can escape those in s/// but I know we can use print:
> > 
> >     s/#authorslist#// and print '$$out'
> > 
> > to tell perl not to even inside $out.
> > 
> > This patch also fixes gen-AUTHORS so that it works in VPATH.
> > ---
> >  Makefile.am | 6 +++---
> >  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> >  gen-AUTHORS:
> > -	$(AM_V_GEN)if test -d .git; then \
> > -	    out="`git log --pretty=format:'%aN <%aE>' | sort -u`" && \
> > -	    cat $(srcdir)/AUTHORS.in | perl -p -e "s/#authorslist#/$$out/" > \
> > +	$(AM_V_GEN)if test -d $(srcdir)/.git; then \
> > +	    out="`cd $(srcdir) && git log --pretty=format:'%aN <%aE>' | sort -u`" && \
> > +	    cat $(srcdir)/AUTHORS.in | perl -p -e "s/#authorslist#// and print '$$out'" > \
> 
> ACK, although this would be a nice time to fix the useless use of cat:
> 
> perl -p -e "s/#authorslist#// and print '$$out'" \
>   < $(srcdir)/AUTHORS.in > $(distdir)/AUTHORS-tmp && \

Yeah, I did that and pushed, thanks. I was too focused on fixing the
perl part :-)

Jirka


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]