[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 5/5] docs: aesthetical cleanups



On 12/18/2012 04:29 AM, Osier Yang wrote:
> On 2012年12月17日 23:17, Martin Kletzander wrote:
>> Removing "exempli gratia" when there should be dots afterwards, also
>> Uppercase letter should be present when starting a sentence.  Sorry
>> for the double line in the last hunk even though it's just adding a
>> word, but it would require to have new sentence starting on a newline
>> and that didn't seem very nice.
>> ---
>>   docs/hacking.html.in | 12 ++++++------
>>   1 file changed, 6 insertions(+), 6 deletions(-)
>>
>> diff --git a/docs/hacking.html.in b/docs/hacking.html.in
>> index 40acdbb..1363779 100644
>> --- a/docs/hacking.html.in
>> +++ b/docs/hacking.html.in
>> @@ -217,7 +217,7 @@
>>       <p>
>>         The keywords<code>if</code>,<code>for</code>,<code>while</code>,
>>         and<code>switch</code>  must have a single space following them
>> -      before the opening bracket. eg
>> +      before the opening bracket. Example:
> 
> Not sure I like this, as I'm a fan of using "e.g.". :-)
> 
> And isn't "e.g." is used everywhere across the project? Should we
> just fix it by s/eg/e.g./?
> 
> Osier

I've no problem with that and will gladly send a v2 for this.

Thanks for the review, I've pushed the ACKed ones.

Martin


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]