[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH v2 0/28] Rename files in src/util to have a 'vir' prefix



On Wed, Dec 19, 2012 at 11:08:43PM +0800, Daniel Veillard wrote:
> On Wed, Dec 19, 2012 at 11:55:20AM +0000, Daniel P. Berrange wrote:
> > Currently the files in src/util are 50/50 split between those
> > having a 'vir' prefix and those which don't. Finish the job
> > by remaining all remaining files to have a 'vir' prefix too,
> > guaranteeing that they can't clash with system headers[1].
> > 
> > The only case which was not a plain rename, was merging
> > processinfo.{c,h} into the virprocess.{c,h} since the
> > functionality logically belongs together.
> > 
> > At the end src/Makefile.am is updated to sort util files
> > alphabetically.
> > 
> > Left as further work - make sure all functions in these
> > files also have a 'vir' prefix. eg dnsmasq, ebtables,
> > iptables, usb and pci files are violators in this regard.
> > 
> > Also left, much of virutil.c should move into virfile.c
> 
>   I have just gone though 1 to 15 included, ACK to that set 
> let's push rather sooner than later as this will be conflicting
> with pending patches and we shouldn't have too many right now.
>   Only suggested addition is change the beginning comment description
> of files like src/util/logging.c
>   to read
>   * virlog.c: internal logging and debugging
> instead of
>   * logging.c: internal logging and debugging

Ah yes. I did all these changes using simple search & replace
of the #include lines, so missed out the places where comments
refer to the filenames. I'll deal with those manually.

>   I also wonder if virbuf, viralloc and virlog headers shouln't be
> added directly to one of the internals as those are used by nearly
> all modules under src/

Yep, I've wondered about that myself on several occassions
too.

Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]