[libvirt] [PATCH] build: Check for broken GCC -Wlogical-op was too optimistic
Eric Blake
eblake at redhat.com
Wed Dec 19 18:49:18 UTC 2012
On 12/19/2012 07:17 AM, Viktor Mihajlovski wrote:
> The check for a broken GCC -Wlogical-op implemententation
> was written under the wrong assumption that unknown warning
> options would be gracefully ignored.
> Thanks to Eric Blake and Daniel Berrange for pointing that
> out.
>
> Signed-off-by: Viktor Mihajlovski <mihajlov at linux.vnet.ibm.com>
> ---
> configure.ac | 8 +++++++-
> 1 file changed, 7 insertions(+), 1 deletion(-)
>
> diff --git a/configure.ac b/configure.ac
> index 20caa92..828ae01 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -260,7 +260,13 @@ dnl which is the case with a certain range of GCC versions
> AC_MSG_CHECKING([whether GCC -Wlogical-op is broken])
>
> save_CFLAGS="$CFLAGS"
> -CFLAGS="-O2 -Wlogical-op -Werror"
> +for w_opt in $WARN_CFLAGS; do
> + case $w_opt in
> + "-Wlogical-op" | "-Werror" )
> + CFLAGS="$CFLAGS $w_opt"
> + ;;
> + esac
> +done
NACK. This still doesn't do what I asked about moving the check into
m4/virt-compile-warnings.m4. Alternate version coming up soon.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 619 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20121219/b7582fbb/attachment-0001.sig>
More information about the libvir-list
mailing list