[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] build: make broken -Wlogical-op test be gcc-only



On Wed, Dec 19, 2012 at 12:24:39PM -0700, Eric Blake wrote:
> Commit 8b8fcdea introduced a check for broken gcc -Wlogical-op,
> but did not guard the check against non-gcc compilers, which might
> lead to spurious failures when another compiler encounters an
> unknown pragma.  Additionally, all of our compiler warning logic
> should belong in a single file, and use cache variables to allow
> overriding the decision at configure time if necessary.
> 
> * configure.ac (BROKEN_GCC_WLOGICALOP): Move...
> * m4/virt-compile-warnings.m4 (LIBVIRT_COMPILE_WARNINGS): ...here,
> and update to modern autoconf idioms.
> ---
> 
> Fixes the issues mentioned here:
> https://www.redhat.com/archives/libvir-list/2012-December/msg01197.html
> https://www.redhat.com/archives/libvir-list/2012-December/msg01211.html
> 
>  configure.ac                | 23 -----------------------
>  m4/virt-compile-warnings.m4 | 22 ++++++++++++++++++++++
>  2 files changed, 22 insertions(+), 23 deletions(-)

ACK


Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]