[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH v2 0/28] Rename files in src/util to have a 'vir' prefix



On 12/19/2012 08:08 AM, Daniel Veillard wrote:
> On Wed, Dec 19, 2012 at 11:55:20AM +0000, Daniel P. Berrange wrote:
>> Currently the files in src/util are 50/50 split between those
>> having a 'vir' prefix and those which don't. Finish the job
>> by remaining all remaining files to have a 'vir' prefix too,
>> guaranteeing that they can't clash with system headers[1].
>>
>   Only suggested addition is change the beginning comment description
> of files like src/util/logging.c
>   to read
>   * virlog.c: internal logging and debugging
> instead of
>   * logging.c: internal logging and debugging

Similar comments to the rest of the series.

>   Someone else do 16 to 24 ? :-)

Done; ACK to the remainder of the series.  Turning on git rename
detection made this review MUCH easier.  There's still a lot of things
we can do further, but I see no problem with getting these patches in now.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]