[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 3/6] Remove QEMU_CAPS_NO_ACPI capability for non-x86 platform



On Thu, Dec 20, 2012 at 02:02:24PM +0800, Li Zhang wrote:
> From: Li Zhang <zhlcindy linux vnet ibm com>
> 
> ACPI is only supported on x86 platform, PPC can't support it.
> So QEMU_CAPS_NO_ACPI shouldn't be set.
> 
> This patch is to remove QEMU_CAPS_NO_ACPI capability for
> non-x86 platform.
> 
> Signed-off-by: Li Zhang <zhlcindy linux vnet ibm com>
> ---
>  src/qemu/qemu_capabilities.c |    8 +++++++-
>  1 file changed, 7 insertions(+), 1 deletion(-)
> 
> diff --git a/src/qemu/qemu_capabilities.c b/src/qemu/qemu_capabilities.c
> index 50d999a..a6ac169 100644
> --- a/src/qemu/qemu_capabilities.c
> +++ b/src/qemu/qemu_capabilities.c
> @@ -2260,7 +2260,13 @@ qemuCapsInitQMPBasic(qemuCapsPtr caps)
>      qemuCapsSet(caps, QEMU_CAPS_DRIVE_CACHE_DIRECTSYNC);
>      qemuCapsSet(caps, QEMU_CAPS_NO_SHUTDOWN);
>      qemuCapsSet(caps, QEMU_CAPS_DRIVE_CACHE_UNSAFE);
> -    qemuCapsSet(caps, QEMU_CAPS_NO_ACPI);
> +
> +    /* ACPI is only supported on x86, PPC or
> +     * other platforms don't support it*/
> +    if (caps->arch == VIR_ARCH_I686 ||
> +        caps->arch == VIR_ARCH_X86_64)
> +        qemuCapsSet(caps, QEMU_CAPS_NO_ACPI);
> +
>      qemuCapsSet(caps, QEMU_CAPS_FSDEV_READONLY);
>      qemuCapsSet(caps, QEMU_CAPS_VIRTIO_BLK_SG_IO);
>      qemuCapsSet(caps, QEMU_CAPS_DRIVE_COPY_ON_READ);

ACK

Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]