[libvirt] [PATCH] qemu: fix QEMU_CAPS_NO_ACPI detection

Viktor Mihajlovski mihajlov at linux.vnet.ibm.com
Fri Dec 21 13:55:16 UTC 2012


On 12/21/2012 02:38 PM, Ján Tomko wrote:
> In commit c4bbaaf8, caps->arch was checked uninitialized, rendering the
> whole check useless.
>
> This patch moves the conditional setting of QEMU_CAPS_NO_ACPI to
> qemuCapsInitQMP, and removes the no longer needed exception for S390.
>
> It also clears the flag for all non-x86 archs instead of just S390 in
> qemuCapsInitHelp.
> ---
>   src/qemu/qemu_capabilities.c |   29 ++++++++---------------------
>   1 files changed, 8 insertions(+), 21 deletions(-)
>

Definitely good to see any S390 special handling become obsolete.
+1 from my side.

-- 

Mit freundlichen Grüßen/Kind Regards
    Viktor Mihajlovski

IBM Deutschland Research & Development GmbH
Vorsitzender des Aufsichtsrats: Martina Köderitz
Geschäftsführung: Dirk Wittkopp
Sitz der Gesellschaft: Böblingen
Registergericht: Amtsgericht Stuttgart, HRB 243294




More information about the libvir-list mailing list