[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 3/8] cpu: Fix PowerPCNodeData



On 12/20/2012 05:01 PM, Jiri Denemark wrote:
> Make getting node CPU data for PowerPC unsupported on other
> architectures. The function is also renamed as ppcNodeData to match
> other functions in PowerPC CPU driver.
> ---
>  src/cpu/cpu_powerpc.c | 26 ++++++++++----------------
>  1 file changed, 10 insertions(+), 16 deletions(-)
> 

> @@ -633,7 +623,11 @@ struct cpuArchDriver cpuDriverPowerPC = {
>      .decode     = PowerPCDecode,
>      .encode     = NULL,
>      .free       = PowerPCDataFree,
> -    .nodeData   = PowerPCNodeData,
> +#if defined(__powerpc__) || defined(__powerpc64__)
> +    .nodeData   = ppcNodeData,
> +#else
> +    .nodeData   = NULL,
> +#endif

Technically, you can omit the #else branch, as all members of C99
initialization that are not specified are left 0-initialized; but I'm
okay if you don't want to change this.

ACK.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]