[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] qemu: Adapt to new log format



On 12/29/2012 02:09 AM, Michal Privoznik wrote:
> Since 586502189edf9fd0f89a83de96717a2ea826fdb0 qemu commit, the log
> lines reporting chardev's path has changed from:
> 
> $ ./x86_64-softmmu/qemu-system-x86_64 -serial pty -serial pty -monitor pty
> char device redirected to /dev/pts/5
> char device redirected to /dev/pts/6
> char device redirected to /dev/pts/7
> 
> to:
> 
> $ ./x86_64-softmmu/qemu-system-x86_64 -serial pty -serial pty -monitor pty
> char device compat_monitor0 redirected to /dev/pts/5
> char device serial0 redirected to /dev/pts/6
> char device serial1 redirected to /dev/pts/7

Why are we even scraping stdout?  If we are using qemu 1.2 or newer,
isn't this information also available from a QMP monitor command?  If
so, we should modify the code to use QMP (which will work regardless of
the change in output in qemu 1.4), and leave the old code for scraping
stdout of qemu 1.1 untouched.

I'm a bit late in reviewing this, since you already pushed, but I'm
inclined to NACK it if we can come up with a better solution using QMP.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]