[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 1/4] Update gnulib to fix mingw64 compilation errors



On 02/01/2012 05:28 PM, Marc-André Lureau wrote:
> ---
>  .gnulib   |    2 +-
>  bootstrap |   16 ++++++++++++----
>  2 files changed, 13 insertions(+), 5 deletions(-)
> 
> diff --git a/.gnulib b/.gnulib
> index dd6b2d7..2f0ed93 160000
> --- a/.gnulib
> +++ b/.gnulib
> @@ -1 +1 @@
> -Subproject commit dd6b2d751b3c6ad417f6a4c48f2adb9d27cc59d2
> +Subproject commit 2f0ed93050ab6d858738d36addd8320889e4a0e0

You beat me to this.  :)  There have indeed been several good upstream
fixes in gnulib worth pulling in:

* .gnulib dd6b2d7...2f0ed93 (55):
  > typo
  > autoupdate
  > popen: Make more robust on Windows.
  > Fix date of recent ChangeLog entries.
  > pclose: Fix typo.
  > doc about getlogin_r, setstate.
  > poll tests: Make test more robust.
  > sys_stat: Fix support for mingw64 and MSVC.
  > wcwidth: Work around bug in UTF-8 locale on OpenBSD 5.0.
  > quotearg: Fix test failure on MacOS X 10.5.
  > maint.mk: sc_prohibit_canonicalize_without_use: avoid false positive
  > autoupdate
  > test-framework-sh: Fix test failure with AIX 7.1 diff.
  > strtoimax: eliminate need for stdint.h, inttypes.h checks
  > sys_time: Override 'struct timeval' on some native Windows platforms.
  > accept4, fcntl, socket modules: Avoid warnings on x86_64 mingw64.
  > fcntl: Avoid compilation error on native Windows.
  > select, poll, isatty: Avoid warnings on x86_64 mingw64.
  > doc: clarify README-release
  > maint.mk: use more readable (yet functionally equivalent) quoting
  > stdalign: relax _Alignof and tighten _Alignas test
  > stdalign: Document the last change.
  > Fix bug# typo in previous patch.
  > stdalign: check that alignof and offsetof are consistent
  > update-copyright: accept new option: UPDATE_COPYRIGHT_USE_INTERVALS=2
  > build-aux/ylwrap: restore x bit
  > pipe2: refine doc about thread-safety
  > posix_spawn_file_actions_addopen: Fix 2012-01-08 commit.
  > pipe2, assign4: document lack of thread-safety in replacement
  > malloca: Avoid warnings on x86_64 mingw64.
  > obstack: remove __STDC__ conditionals
  > havelib: Modern quoting.
  > stdint: Improve support for Android.
  > doc: omit trailing empty lines from INSTALL etc.
  > tests: avoid spurious warnings about gl_sockets_startup
  > locale-fr.m4: Fix for Android.
  > bootstrap: fail when bootstrap_post_import_hook fails
  > update from texinfo
  > maint: enable sc_trailing_blank
  > maint: enable sc_prohibit_openat_without_use
  > maint: enable sc_prohibit_cloexec_without_use
  > maint: enable sc_prohibit_intprops_without_use
  > maint: enable sc_prohibit_hash_pjw_without_use
  > maint: enable double-word-prohibiting rule
  > maint: remove empty lines at EOF, but excluding modules/*
  > maint: add framework to run syntax-check rules against gnulib sources
  > stdint: Add support for Android.
  > autoupdate
  > bootstrap: add bootstrap_post_import_hook
  > gitlog-to-changelog: don't use "no_"-prefixed variable name
  > gitlog-to-changelog: use "||", not "or" in expressions
  > gitlog-to-changelog: new option --no-cluster
  > maint: spell file systems with two words, not one
  > fix a typo
  > bootstrap: add a FIXME comment to ensure we eventually remove the hack


ACK and pushed.  I'll review the rest of your series later (ran out of
time today); I suspect there's still some pid_t mis-uses to be cleaned
up first.  Fortunately, beyond the gnulib update, I don't mind making
the rest of these sort of changes even after the freeze.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]