[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] virterror.c: Fix several spelling mistakes



On 02/03/2012 11:20 AM, Philipp Hahn wrote:
> compat{a->i}bility
> erron{->e}ous
> nec{c->}essary.
> Either "the" or "a".
> 
> Signed-off-by: Philipp Hahn <hahn univention de>
> ---

ACK and pushed, after fixing one nit.

>  ChangeLog-old                 |   36 ++++++++++++++++++------------------

Changing history always feels suspect, but I guess it's okay.

> @@ -3591,7 +3591,7 @@ Thu Jan 15 19:54:19 GMT 2009  Daniel P. Berrange <berrange redhat com>
>  	* src/Makefile.am, src/threads.c, src/threads.h: Generic internal API for threads
>  	* src/threads-pthread.c, src/threads-pthread.h: UNIX pthreads impl
>  	* src/threads-win32.c, src/threads-win32.h: Win32 threads impl
> -	* src/internal.h: Remove unnneccessary pthreads macros
> +	* src/internal.h: Remove unnecessary pthreads macros

We really loaded up on the extra letters there :)

> +++ b/docs/migration.html.in
> @@ -25,7 +25,7 @@
>        on the hypervisor in question, but will typically have the lowest computational costs
>        by minimising the number of data copies involved. The native data transports will also

I didn't bother changing this, but if we want to prefer US spelling
instead of UK in the web pages, then we would use minimizing here.

> @@ -6025,7 +6025,7 @@ and check the <a href="http://libvirt.org/git/?p=libvirt.git;a=log";>GIT log</a>
>          Fix a typo in virDiskHasValidPciAddr() (Jiri Denemark),<br/>
>          Fix a number of small typos (Dan Kenigsberg),<br/>
>          add doc for graphic and video elements (Florian Vichot),<br/>
> -        Fix up 'neccessary -&gt; necessary' in a comment. (Chris Lalancette),<br/>
> +        Fix up 'necessary -&gt; necessary' in a comment. (Chris Lalancette),<br/>

This change actually breaks the description of the actual bug fix, so I
reverted this hunk.

You know, maybe we should add a syntax check rule that catches some of
the common misspellings that have been prone to re-occur in our sources.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]