[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] xen-xm: fix data loss in domain edit



On 02/06/2012 06:09 AM, Philipp Hahn wrote:
> On CentOS5:
> If "virsh edit $DOM" is used and an error happens (for example changing
> any live cycle action to a non-existing value), libvirt forgets that
> $DOM exists, since it is already removed from the internal hash tables,
> which are used for domain lookup.
> In once case (unreproducible) even the persistent configuration
> /etc/xen/$DOM was deleted.
> 
> Instead of using the compound function xenXMConfigSaveFile() explicitly
> use xenFomatXM() and virConfWriteFile() to distinguish between a failure
> in converting the libvirt definition to the xen-xm format and a problem
> when writing the file.
> 
> Signed-off-by: Philipp Hahn <hahn univention de>
> ---
>  src/xen/xm_internal.c |    7 ++++++-
>  1 files changed, 6 insertions(+), 1 deletions(-)

ACK and pushed.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]