[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] pyhton: Don't link against libvirt_util.la



On 07.02.2012 13:49, Daniel P. Berrange wrote:
> On Tue, Feb 07, 2012 at 01:41:52PM +0100, Michal Privoznik wrote:
>> As we already link with libvirt.la which contains libvirt_utils.la.
>> Double linking causes global symbols to be presented twice and
>> thus confusion. This partially reverts c700613b8d463212d142c97108b7a2352e23e559
>> ---
>>  python/Makefile.am |    2 --
>>  1 files changed, 0 insertions(+), 2 deletions(-)
>>
>> diff --git a/python/Makefile.am b/python/Makefile.am
>> index 9b791d7..0305bcc 100644
>> --- a/python/Makefile.am
>> +++ b/python/Makefile.am
>> @@ -41,11 +41,9 @@ EXTRA_DIST =			\
>>  if WITH_PYTHON
>>  mylibs = \
>>  	$(top_builddir)/src/libvirt.la \
>> -	$(top_builddir)/src/libvirt_util.la \
>>  	$(top_builddir)/gnulib/lib/libgnu.la
>>  myqemulibs = \
>>  	$(top_builddir)/src/libvirt-qemu.la \
>> -	$(top_builddir)/src/libvirt_util.la \
>>  	$(top_builddir)/gnulib/lib/libgnu.la
>>  
>>  all-local: libvirt.py libvirt_qemu.py
> 
> ACK
> 
> 
> Daniel

Thanks, pushed.

Michal


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]