[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] build: don't require avahi during install



On 02/07/2012 03:23 AM, Laine Stump wrote:
> See: https://bugzilla.redhat.com/show_bug.cgi?id=785269
> 
> The specfile requires avahi during install if libvirt was built with
> avahi support, but there are many situations where it is undesirable
> to install avahi due to security concerns. If we still Build-require
> avahi-devel during the build, but don't require it at install time, it
> will be used if present, and ignored if not.
> ---
>  libvirt.spec.in |    3 ---
>  1 files changed, 0 insertions(+), 3 deletions(-)

ACK to this change, but I'm worried that it might be imcomplete.  You
are effectively reverting commit cbc702594, but that commit mentioned
that libvirtd built with avahi support but avahi not installed refuses
to boot.  Did you actually test that scenario?  I'd feel more
comfortable knowing for sure in the commit message that you tested that
libvirt can start up without error no matter what state avahi is in
(including not installed).

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]